Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flake8 to pre-commit #13

Merged
merged 19 commits into from
Dec 6, 2023
Merged

Add flake8 to pre-commit #13

merged 19 commits into from
Dec 6, 2023

Conversation

grothe6
Copy link
Contributor

@grothe6 grothe6 commented Jul 21, 2023 •
edited
Loading

Add static analysis with flake8 and mypy to pre-commit.
Related to #7.

We will need to fix all flake8 and mypy issues before merging this.
Related PR: #28

Edit: We will first fix flake8, later mypy.

@github-actions
Copy link

github-actions bot commented Jul 21, 2023 •
edited
Loading

Test Results

  3 files  ±0    3 suites  ±0   8s ⏱️ -3s
24 tests ±0  24 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
72 runs  ±0  72 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0ba3a6e. ± Comparison against base commit 464aa54.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 21, 2023 •
edited
Loading

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/qumada/instrument/buffers/sr830_buffer.py 28.57% <ø> (ø)
src/qumada/instrument/mapping/base.py 45.62% <100.00%> (ø)
src/qumada/measurement/scripts/__init__.py 100.00% <100.00%> (ø)
src/qumada/metadata.py 80.00% <ø> (ø)
src/qumada/utils/generate_sweeps.py 18.75% <100.00%> (ø)
src/qumada/utils/resources.py 0.00% <ø> (ø)
...ada/instrument/custom_drivers/Dummies/dummy_dac.py 56.66% <0.00%> (ø)
...umada/instrument/custom_drivers/Harvard/Decadac.py 0.00% <0.00%> (ø)
src/qumada/instrument/custom_drivers/ZI/MFLI.py 15.38% <0.00%> (ø)
src/qumada/measurement/measurement.py 30.79% <75.00%> (+0.22%) ⬆️
... and 12 more

📢 Thoughts on this report? Let us know!.

@grothe6 grothe6 force-pushed the feature/gh-actions-pylint-mypy branch from 519a15c to 9fb0c3b Compare July 21, 2023 11:58
@grothe6 grothe6 force-pushed the feature/gh-actions-pylint-mypy branch from c137995 to 6d01df6 Compare August 14, 2023 07:06
@grothe6 grothe6 changed the title Add pylint and mypy to CI Add flake8 and mypy to CI Aug 14, 2023
@grothe6 grothe6 force-pushed the feature/gh-actions-pylint-mypy branch from cfb7fcd to af34d47 Compare August 14, 2023 12:37
@grothe6 grothe6 changed the title Add flake8 and mypy to CI Add flake8 and mypy to pre-commit Aug 14, 2023
@grothe6 grothe6 force-pushed the feature/gh-actions-pylint-mypy branch from 563c127 to 8601066 Compare August 14, 2023 15:28
grothe6 and others added 3 commits August 14, 2023 17:41
@grothe6
Ignore example files for flake8 and mypy.
23459c7 
This should be reverted, when working on these files.

Related issue #18
@grothe6
temporarily remove mypy from pre-commit
4e8b52b
@grothe6
Merge pull request #28 from qutech/fix/flake8-and-mypy
7884b1b 
Fix errors from flake8
@grothe6 grothe6 changed the title Add flake8 and mypy to pre-commit Add flake8 to pre-commit Oct 13, 2023
@grothe6 grothe6 merged commit f784c2c into main Dec 6, 2023
7 checks passed
@grothe6 grothe6 deleted the feature/gh-actions-pylint-mypy branch December 6, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@THuckemann THuckemann Awaiting requested review from THuckemann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@grothe6